Skip to content

chore: upgrade feature-assess to gh-aw v0.88.7 - #4546

Merged
mnriem merged 3 commits into
github:mainfrom
KSchlobohm:chore/feature-assess-gh-aw-v0.88.7
Sep 15, 2026
Merged

mnriem merged 3 commits into
github:mainfrom
KSchlobohm:chore/feature-assess-gh-aw-v0.88.7

Conversation

@KSchlobohm

@KSchlobohm KSchlobohm commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrade feature-assess from gh-aw v0.79.8 to v0.88.7 and Copilot engine 1.0.80.

Changes

  • Regenerate .github/workflows/feature-assess.lock.yml.
  • Add the immutable setup-cli action pin.
  • Adapt the local Spec Kit installation command for gh-aw v0.88.7 package validation.
  • Add positive and negative regression tests for setup behavior, triggers, permissions, safe outputs, verdict labels, and action pins.

No other workflows are upgraded.

Validation

gh aw compile feature-assess --strict --validate
  1 succeeded, 0 warnings

pytest tests/test_github_workflows.py -k feature_assess_upgrade -v
  2 passed

ruff check tests/test_github_workflows.py
  Passed

git diff --check
  Passed

Fork end-to-end tests:

  • Positive test: five ordered assessment comments and one feature-needs-clarification verdict.
  • Negative test: stopped after intake and applied only feature-invalid.
  • All six workflow jobs succeeded in both positive and negative runs.

These are integration smoke tests, not a comprehensive evaluation of assessment accuracy.

Agent disclosure

Authored and submitted on behalf of @KSchlobohm by GitHub Copilot (model: GPT-5.6 Sol, autonomous).

Regenerate the feature assessment workflow on the current upstream baseline and add positive and negative compatibility checks.

Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 11, 2026 21:28
@KSchlobohm
KSchlobohm marked this pull request as ready for review September 11, 2026 21:31
@KSchlobohm
KSchlobohm requested a review from mnriem as a code owner September 11, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Add assertions covering the labeled issue trigger and safe_outputs permissions.

Get a fresh assessment by requesting another Copilot review.

Review tier: Lite (auto)
Findings: 2 Medium severity

Note

Copilot is running an experiment and ran this review at Lite.

Open findings (2)
What changed in this PR

Upgrades feature-assess to gh-aw v0.88.7 and Copilot 1.0.80, with updated CLI setup and regression coverage.

Changes:

  • Regenerates the compiled workflow.
  • Adds the immutable setup-cli pin.
  • Updates Spec Kit installation validation.
  • Adds workflow regression tests.
File Summary
tests/​test_github_workflows.py Adds upgrade checks; trigger preservation and safe_outputs permission assertions remain needed.
.github/​workflows/​feature-assess.md Updates local Spec Kit installation.
.github/​workflows/​feature-assess.lock.yml Regenerated workflow for gh-aw v0.88.7.
.github/​aw/​actions-lock.json Adds the pinned setup-cli action.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/test_github_workflows.py Outdated
Comment thread tests/test_github_workflows.py
Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 11, 2026 21:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Four moderate regression-test findings remain unresolved.

Review tier: Lite (auto)
Findings: 1 Medium severity

Note

Copilot is running an experiment and ran this review at Lite.

Open findings (1)
Resolved findings (1)
Previously missed findings (1)

In code that hasn't changed since last review

Medium severity Make the trigger regression test enforce the full trigger

tests/​test_github_workflows.py:239

This regression only checks that the label expression appears as a substring; it never asserts the issues: labeled trigger and would pass if an unrelated event or label were added. Assert the parsed trigger and complete if expressions (or exercise representative feature/non-feature events) so the test actually proves this workflow cannot activate for other triggers.

Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 11, 2026 22:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The workflow and security-sensitive generated configuration changes warrant final human review.

Review tier: Lite (auto)
Findings: None

Note

Copilot is running an experiment and ran this review at Lite.

Resolved findings (1)

@mnriem mnriem added the triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review label Sep 12, 2026
@mnriem
mnriem merged commit 319fb84 into github:main Sep 15, 2026
15 checks passed
@mnriem

mnriem commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

@KSchlobohm
KSchlobohm deleted the chore/feature-assess-gh-aw-v0.88.7 branch September 16, 2026 20:51
mnriem added a commit that referenced this pull request Sep 17, 2026
* Update Status Report extension to v1.4.2

Update status-report extension submitted by @jwesleye:
- extensions/catalog.community.json (version, download_url, effect, requires, etc.)
- docs/community/extensions.md community extensions table

Closes #4519

Assisted-by: GitHub Copilot (model: gpt-5.2-codex, autonomous)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: simplify README around three processes (#4591)

* docs: simplify README around three processes

Use one shared setup and independent SDD, bug-fixing, and idea-assessment quickstarts. Consolidate detailed content into the docs and contributor guide, add missing process guides, align Chinese documentation, and preserve navigation without widening the site header.

Assisted-by: GitHub Copilot (model: gpt-6-astra, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* docs: distinguish agent skills from terminal setup

Explicitly describe workflow steps as skills invoked in the agent chat, while reserving terminal instructions for CLI installation and project or extension setup.

Assisted-by: GitHub Copilot (model: gpt-6-astra, autonomous)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Bound speckit.clarify planning deferral to implementation details (#4507)

* Gate speckit.clarify so spec-taxonomy items are not deferred to plan

The command treated "better deferred to planning" as a catch-all, so
agents skipped NFRs, acceptance criteria, and edge cases. Spec hits
must stay question candidates. Defer only implementation method,
tech-stack comparison, or task breakdown.

Fixes #1717

* Bound clarify planning deferral to implementation and tech-stack

The unbounded "better deferred to planning" catch-all is gone. Spec
taxonomy still lives in the command. Stage-gate procedure and defer-ratio
audit belong in an opt-in wrap preset, not core.

* Bound the clarify completion-report Deferred status too.

The candidate-question skip was already limited to implementation method, tech-stack, or task breakdown. The coverage table still called anything "better suited for planning" Deferred. That leftover catch-all is gone, and the test now covers the report.

* fix(integrations): dispatch bob commands via `bob run` (#4492)

* fix(integrations): dispatch bob commands via `bob run`

`BobIntegration` never overrode `build_exec_args()`, so it inherited the
`IntegrationBase` no-op returning `None`. Callers read `None` as "this CLI is
unavailable", so every workflow command/prompt step targeting Bob reported
`CLI not found or not installed` even with `bob` on PATH.

`build_command_invocation()` was inherited too, rendering `/speckit.specify`
where skills-mode projects install `.bob/skills/speckit-specify/`.

* fix(integrations): resolve the command layout from the project being dispatched into

`build_command_invocation()` called `effective_invoke_separator()` with no
arguments, so `is_skills_mode()` never reached its disk-detection branch
(bob/__init__.py:223-228) and always returned the fresh-project default.
`dispatch_command()` does receive the workflow project root, but the shared
two-argument `build_command_invocation(command_name, args)` contract -- which
eight integrations implement -- had nowhere to put it.

Two consequences, measured against a real `.bob/commands/speckit.specify.md`
project:

  legacy project, speckit.specify     -> /speckit-specify        (want /speckit.specify)
  skills project, speckit.git.commit  -> /speckit-git.commit     (want /speckit-git-commit)

(a) Every existing Bob 1.x install is dispatched a skills-mode invocation
naming a command it does not have, so the run fails exactly as it did before
dispatch was implemented.

(b) Only the `speckit.` prefix was converted, leaving inner dots. The
installed skill directory is `speckit-git-commit` -- `SkillsIntegration`
derives it with `stem.replace(".", "-")` (base.py:1759) and renders the
invocation the same way (base.py:1649) -- so a dotted extension command names
a skill that does not exist. The two layouts differ in both the separator and
the dot handling: skills flatten every dot, legacy commands keep them.

`_build_dispatch_prompt()` carries the project root from `dispatch_command()`
into invocation building. The base implementation is the call it replaces, so
the other integrations are unaffected; Bob overrides it to resolve the layout
from disk, falling back to the working directory, which is where
`dispatch_command` runs `bob` when no root is given.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TqDT4qTj3sFBeg9tMRiXqZ

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* chore: release 1.0.7, begin 1.0.8.dev0 development (#4592)

* chore: bump version to 1.0.7

* chore: begin 1.0.8.dev0 development

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: upgrade feature-assess to gh-aw v0.88.7 (#4546)

* chore: upgrade feature-assess to gh-aw v0.88.7

Regenerate the feature assessment workflow on the current upstream baseline and add positive and negative compatibility checks.

Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test: assert feature-assess safe output permissions

Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test: enforce feature-assess trigger guards

Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update adrkit extension to v0.1.4 (#4600)

Update adrkit extension submitted by @mbeacom:
- extensions/catalog.community.json (version, download_url, compatibility range)
- docs/community/extensions.md community extensions table (no row changes required)

Closes #4571

Assisted-by: GitHub Copilot (model: gpt-5.2-codex, autonomous)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update Azure Cosmos DB extension to v0.2.0 (#4602)

Update cosmosdb extension submitted by @TheovanKraay:\n- extensions/catalog.community.json (version, download_url, and timestamps)\n- docs/community/extensions.md community extensions table (already current)\n\nCloses #4579\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>\nAssisted-by: GitHub Copilot (model: gpt-5.2-codex, autonomous)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add OpenUP Governed Lifecycle extension to community catalog (#4598)

Add openup extension submitted by @anvigo12 to the community catalog and documentation. Closes #4567. Assisted-by: GitHub Copilot (model: gpt-5.2-codex, autonomous)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add OpenUP Governance preset to community catalog (#4596)

Add openup-governance preset submitted by @anvigo12 to the community catalog and documentation table.

Closes #4568

Assisted-by: GitHub Copilot (model: gpt-5.2-codex, autonomous)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Manfred Riem <15701806+mnriem@users.noreply.github.com>
Co-authored-by: Gyanu Mayank <gyanumayank0@gmail.com>
Co-authored-by: temp-droid <82510451+temp-droid@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Ken Schlobohm <keschlob@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants